A long table lay straight across the gap between two sheets with a row cut in half, and a shorter one jumped to the next sheet whole leaving the rest of the first blank. Tables are broken between their rows now, which is where a table breaks on paper. The spacer there is a tr with one borderless cell: a div inside a tbody is not something the browser keeps. Its own spacer rows are subtracted again on the next measurement and counted into the shift every block below inherits — miss that and everything under a broken table is measured a page too high. A dialog closed in the middle of an edit if a selection was dragged past its edge: the click lands on the nearest common ancestor of press and release, which is the backdrop, and every dialog read that as "clicked beside me". They remember where the press began now. All ten. A note and a chapter can wear a mark of their own beside the name, chosen from a short list searched by what a thing is for rather than from the system emoji keyboard — a different thing on every machine, and three thousand pictures for a decision that is "which of these is the invoice notebook". A separator takes its own colour and one of five shapes, and a chapter can be divided like the notebook it sits in: both places a chapter is shown draw it with one component now, so it cannot be divisible in the column and not in the unfolded block. Also: a chapter's colour could not be cleared, because the update rode on COALESCE and null there means "leave it alone". A table's header row is legible on the dark theme. Three entries in the table's own menu were still German. Opening a notebook opens its first note, on a wide screen only — on a phone the list is the screen. Fourteen suites green: 364 browser checks, 241 unit tests. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
182 lines
5.4 KiB
React
182 lines
5.4 KiB
React
import { useEffect, useMemo, useRef, useState } from "react";
|
|
import { useBackdropClose } from "./backdrop";
|
|
|
|
/**
|
|
* Asking for one name.
|
|
*
|
|
* A real dialog rather than `window.prompt`, for the same reasons the link
|
|
* dialog is one: the browser's box cannot be styled, cannot be reached by the
|
|
* tests, and on a phone it arrives as a system alert with the app greyed out
|
|
* behind it.
|
|
*
|
|
* Deliberately small. Naming a chapter is one field and two buttons, and
|
|
* anything more would be a form.
|
|
*
|
|
* The one exception is the colour, offered when `colors` is given: it belongs to
|
|
* the same act. Making a chapter and then having to right-click it to say which
|
|
* one it is meant two steps for one decision.
|
|
*/
|
|
export function NameDialog({
|
|
title,
|
|
value = "",
|
|
label = "Name",
|
|
confirmLabel = "Save",
|
|
colors,
|
|
color: initialColor = null,
|
|
onSave,
|
|
onClose,
|
|
dark,
|
|
}) {
|
|
const [name, setName] = useState(value);
|
|
const [color, setColor] = useState(initialColor);
|
|
const backdrop = useBackdropClose(onClose);
|
|
const inputRef = useRef(null);
|
|
|
|
const T = useMemo(
|
|
() => ({
|
|
bg: dark ? "#161b22" : "#fff",
|
|
border: dark ? "#30363d" : "#d0d7de",
|
|
text: dark ? "#e6edf3" : "#1f2328",
|
|
muted: dark ? "#8b949e" : "#656d76",
|
|
accent: dark ? "#388bfd" : "#0969da",
|
|
field: dark ? "#0d1117" : "#f6f8fa",
|
|
}),
|
|
[dark]
|
|
);
|
|
|
|
useEffect(() => {
|
|
inputRef.current?.focus();
|
|
inputRef.current?.select();
|
|
}, []);
|
|
|
|
const ready = !!name.trim();
|
|
|
|
const save = () => {
|
|
if (!ready) return;
|
|
onSave(name.trim(), color);
|
|
onClose();
|
|
};
|
|
|
|
return (
|
|
<div
|
|
data-name-dialog
|
|
{...backdrop}
|
|
style={{
|
|
position: "fixed",
|
|
inset: 0,
|
|
background: "rgba(0,0,0,0.5)",
|
|
display: "flex",
|
|
alignItems: "center",
|
|
justifyContent: "center",
|
|
zIndex: 4000,
|
|
padding: 16,
|
|
}}
|
|
>
|
|
<div
|
|
onClick={(e) => e.stopPropagation()}
|
|
style={{
|
|
width: "100%",
|
|
maxWidth: 380,
|
|
background: T.bg,
|
|
border: `1px solid ${T.border}`,
|
|
borderRadius: 16,
|
|
padding: 22,
|
|
fontFamily: "'DM Sans',sans-serif",
|
|
}}
|
|
>
|
|
<h3 style={{ margin: "0 0 14px", fontSize: 16, fontWeight: 700, color: T.text }}>{title}</h3>
|
|
<input
|
|
ref={inputRef}
|
|
value={name}
|
|
onChange={(e) => setName(e.target.value)}
|
|
aria-label={label}
|
|
placeholder={label}
|
|
onKeyDown={(e) => {
|
|
if (e.key === "Enter") save();
|
|
if (e.key === "Escape") onClose();
|
|
}}
|
|
style={{
|
|
width: "100%",
|
|
padding: "10px 14px",
|
|
borderRadius: 10,
|
|
border: `1px solid ${T.border}`,
|
|
background: T.field,
|
|
color: T.text,
|
|
fontSize: 14,
|
|
outline: "none",
|
|
boxSizing: "border-box",
|
|
}}
|
|
/>
|
|
{colors?.length > 0 && (
|
|
<div style={{ marginTop: 16 }}>
|
|
<div style={{ fontSize: 11.5, color: T.muted, fontWeight: 600, marginBottom: 8 }}>Colour</div>
|
|
<div style={{ display: "flex", flexWrap: "wrap", gap: 8 }}>
|
|
{[{ label: "None", value: null }, ...colors].map((c) => {
|
|
const picked = (c.value ?? null) === (color ?? null);
|
|
return (
|
|
<button
|
|
key={c.label}
|
|
type="button"
|
|
onClick={() => setColor(c.value ?? null)}
|
|
title={c.label}
|
|
aria-label={c.label}
|
|
aria-pressed={picked}
|
|
data-colour-option={c.value ?? "none"}
|
|
style={{
|
|
width: 28,
|
|
height: 28,
|
|
borderRadius: 9,
|
|
cursor: "pointer",
|
|
// The ring, not a tick: a tick over a dark swatch is
|
|
// unreadable and over a light one it is the only thing seen.
|
|
border: picked ? `2px solid ${T.text}` : `1px solid ${T.border}`,
|
|
background: c.value ?? "transparent",
|
|
color: T.muted,
|
|
fontSize: 11,
|
|
lineHeight: 1,
|
|
}}
|
|
>
|
|
{c.value ? "" : "—"}
|
|
</button>
|
|
);
|
|
})}
|
|
</div>
|
|
</div>
|
|
)}
|
|
<div style={{ display: "flex", justifyContent: "flex-end", gap: 8, marginTop: 18 }}>
|
|
<button
|
|
onClick={onClose}
|
|
style={{
|
|
padding: "8px 16px",
|
|
borderRadius: 10,
|
|
border: `1px solid ${T.border}`,
|
|
background: "transparent",
|
|
color: T.text,
|
|
cursor: "pointer",
|
|
fontSize: 13,
|
|
}}
|
|
>
|
|
Cancel
|
|
</button>
|
|
<button
|
|
onClick={save}
|
|
disabled={!ready}
|
|
style={{
|
|
padding: "8px 18px",
|
|
borderRadius: 10,
|
|
border: "none",
|
|
background: ready ? T.accent : T.border,
|
|
color: "#fff",
|
|
cursor: ready ? "pointer" : "default",
|
|
fontSize: 13,
|
|
fontWeight: 600,
|
|
}}
|
|
>
|
|
{confirmLabel}
|
|
</button>
|
|
</div>
|
|
</div>
|
|
</div>
|
|
);
|
|
}
|