Make weather update interval configurable, was hardcoded to 30 min
Screen.poll_interval was a fixed class attribute the scheduler read directly -- added Screen.get_poll_interval(settings) so a screen can make it settings-driven instead. WeatherScreen overrides it to read a new "update_minutes" field (default 30, matching the old hardcoded value). New number input on the Weather settings page. Caught a real edge case while testing: `raw or 30` treats an explicit 0 as falsy and silently replaces it with 30 instead of clamping to the 1-minute floor. Not reachable via the UI (min="1" on the input) but the method should still be correct standalone -- fixed with an explicit None-check instead.
This commit is contained in:
1 parent
15c7c38d86
commit
889c062212
5 files changed
+29
-3
No files matched your search
@@ -68,6 +68,7 @@ def create_app(config, screens: dict, scheduler) -> Flask:
|
||||
forecast_days = int(request.form.get("forecast_days", 3) or 3)
|
||||
if forecast_days not in (3, 5, 7):
|
||||
forecast_days = 3
|
||||
update_minutes = max(1, int(request.form.get("update_minutes", 30) or 30))
|
||||
|
||||
if city:
|
||||
try:
|
||||
@@ -82,6 +83,7 @@ def create_app(config, screens: dict, scheduler) -> Flask:
|
||||
"latitude": result["latitude"],
|
||||
"longitude": result["longitude"],
|
||||
"forecast_days": forecast_days,
|
||||
"update_minutes": update_minutes,
|
||||
})
|
||||
return redirect(url_for("settings_weather", saved=1))
|
||||
else:
|
||||
@@ -90,6 +92,7 @@ def create_app(config, screens: dict, scheduler) -> Flask:
|
||||
"latitude": float(lat_raw) if lat_raw else None,
|
||||
"longitude": float(lon_raw) if lon_raw else None,
|
||||
"forecast_days": forecast_days,
|
||||
"update_minutes": update_minutes,
|
||||
})
|
||||
return redirect(url_for("settings_weather", saved=1))
|
||||
|
||||
|
||||
@@ -29,6 +29,11 @@
|
||||
<option value="7" {{ "selected" if settings.forecast_days == 7 }}>7 days</option>
|
||||
</select>
|
||||
</div>
|
||||
<div class="field">
|
||||
<label for="update_minutes">Update every (minutes)</label>
|
||||
<input type="number" id="update_minutes" name="update_minutes" min="1" value="{{ settings.update_minutes or 30 }}">
|
||||
<p class="hint">Weather itself only refreshes the panel when something actually changed, so a shorter interval here mostly just means fresher data, not more flashing.</p>
|
||||
</div>
|
||||
</div>
|
||||
|
||||
<div class="card">
|
||||
|
||||
Reference in new issue
Block a user