Docker/NovaSonic
0
0 Fork 0
Code Issues 15 Pull Requests Actions Packages Projects 1 Releases 1 Wiki Activity

fix: prevent 9-second downloads caused by short iTunes duration match

Browse Source 
When iTunes enrichment returns a jingle/preview as the first result (e.g.
trackTimeMillis=9000), the yt-dlp duration filter becomes impossible
(duration > 30 & duration < 24), all filtered steps fail, and the final
unfiltered fallback downloads whatever YouTube returns first — often a
short clip.

Fix 1: spotify.js — only copy iTunes trackTimeMillis to durationMs when
it is > 30 seconds (genuine song, not a jingle or preview).

Fix 2: ytdlp.js — only enter the duration-filtered search branch when
durationMs > 30 000ms, so a corrupted short value silently falls back to
the unfiltered search path which still finds the correct full song.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This commit is contained in:
HoneyandClaude Sonnet 4.6 committed 2026-05-28 00:06:33 +02:00
1 parent 3db71c24a4
commit 2df5a54985
2 files changed
+4 -2
Download Patch File Download Diff File Expand all files Collapse all files

No files matched your search

backend/lib/ytdlp.js
+1 -1
View File
@@ -215,7 +215,7 @@ async function downloadTrack({ jobId, artist, rawArtist, albumArtist, title, alb
await spawnYtdlp([...urls, '--max-downloads', '1', ...mfArgs, ...baseArgs]); await spawnYtdlp([...urls, '--max-downloads', '1', ...mfArgs, ...baseArgs]);
}; };
if (durationMs) { if (durationMs && durationMs > 30000) {
const durationSec = Math.round(durationMs / 1000); const durationSec = Math.round(durationMs / 1000);
const margin = Math.max(15, Math.round(durationSec * 0.15)); const margin = Math.max(15, Math.round(durationSec * 0.15));
const dur = { min: Math.max(30, durationSec - margin), max: durationSec + margin }; const dur = { min: Math.max(30, durationSec - margin), max: durationSec + margin };
src/spotify.js
+3 -1
View File
@@ -305,7 +305,9 @@ async function _loadSpotifyTrackArtwork(tracks, listEl) {
if (match.collectionName) t.collectionName = match.collectionName; if (match.collectionName) t.collectionName = match.collectionName;
if (match.releaseDate) t.releaseDate = match.releaseDate; if (match.releaseDate) t.releaseDate = match.releaseDate;
if (match.trackNumber) t.trackNumber = match.trackNumber; if (match.trackNumber) t.trackNumber = match.trackNumber;
if (match.trackTimeMillis) t.durationMs = match.trackTimeMillis; // Only use iTunes duration if it looks like a full song (> 30s) — jingles/previews
// returning a small trackTimeMillis would corrupt the yt-dlp duration filter.
if (match.trackTimeMillis > 30000) t.durationMs = match.trackTimeMillis;
} }
if (window._spotifyResolved?.tracks?.[idx]) Object.assign(window._spotifyResolved.tracks[idx], t); if (window._spotifyResolved?.tracks?.[idx]) Object.assign(window._spotifyResolved.tracks[idx], t);
const url = match.artworkUrl100 || match.artworkUrl60 || ''; const url = match.artworkUrl100 || match.artworkUrl60 || '';