Replace unused vector clocks with a conflict check that works, drop the rest

The vector clocks in the server were never reached: no client sent one,
so the branch was dead and every write was a blind overwrite. Not "the
newer edit wins" — "the request that arrives last wins", which is worse:
a phone that was offline all day buries the laptop's newer work simply by
reconnecting late.

Each write now carries baseUpdatedAt, the revision it was written on top
of. If the note has moved on since, the incoming edit still wins — a
rejection would throw away what was just typed — but the state it
replaces is kept as a version marked "conflict", so both exist and the
history is where you choose. Clocks could have told a real conflict from
a device catching up, but that precision only pays off with a merge
interface, and this reuses the version history already built.

adoptRevision() stores the revision the server reports back, or the
second save in a row would be flagged as conflicting with the first.

Also removed, as agreed:
- POST /api/notes/pdf — accepted PDFs that nothing could ever read back,
  with no retrieval route and no viewer. The readme advertised "PDF
  Import & Annotation"; that claim is gone too.
- POST /api/sync — a batch endpoint the client never called.
- the tags column — notebooks, starring and search already cover it.

Columns on existing databases are left in place. Dropping them buys
nothing and is not worth touching a live database for.

Tables now have a right-click menu (editor/tableMenu.js) for rows,
columns, header and merging. It needs stopPropagation: without it the
same event reaches window, where the menu that is mounting reads it as a
click elsewhere and closes instantly — the reason the other context menus
in App.jsx already do this.

92 browser checks across seven suites, 125 unit tests.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This commit is contained in:
marcandClaude Opus 5 committed 2026-08-08 18:59:08 +02:00
1 parent 8c36c6121b
commit df279a5d36
10 files changed
+367 -152

No files matched your search

+30
View File
@@ -44,6 +44,36 @@ try {
await p.screenshot({ path: `${OUT}/editor-content.png` });
/* ── right-click menu on the table ── */
const cellCount = () => p.locator(".ProseMirror table td, .ProseMirror table th").count();
const before = await cellCount();
await p.locator(".ProseMirror table td").first().click({ button: "right" });
await p.waitForTimeout(600);
check((await p.getByText("Zeile darunter einfügen").count()) > 0, "right-click in a table opens the table menu");
check((await p.getByText("Tabelle löschen").count()) > 0, "and offers deleting the table");
await p.screenshot({ path: `${OUT}/editor-table-menu.png` });
await p.getByText("Zeile darunter einfügen").click();
await p.waitForTimeout(1000);
check((await cellCount()) > before, "the menu really added a row", `${before} → ${await cellCount()}`);
const withRow = await cellCount();
await p.locator(".ProseMirror table td").first().click({ button: "right" });
await p.waitForTimeout(600);
await p.getByText("Zeile löschen").click();
await p.waitForTimeout(1000);
check((await cellCount()) < withRow, "and removing one works too", `${withRow} → ${await cellCount()}`);
// Outside a table the browser's own menu must stay available.
await p.locator(".ProseMirror p").first().click({ button: "right" });
await p.waitForTimeout(500);
check(
(await p.getByText("Zeile darunter einfügen").count()) === 0,
"right-click outside a table shows no table menu"
);
await p.keyboard.press("Escape");
await p.waitForTimeout(400);
/* ── a second note to link to ── */
await setTitle(p, "Quelle");
await createNote(p);