One direction to drop in, and a new note that stays on top
Every new note pulled the arrangement apart. A note was made with no position and left to the tie-break, which put it near the top by age -- which is not the same thing. A separator's position counts the rows above it, so a row appearing without a renumber left every line one row too high. placeOnTop builds the order from the list *without* the new note and puts it in front: measuring the room after the furniture has moved would write the misreading back as the truth. A drop now lands the row under the one it was released on, and only there. Dropping above a row and dropping below the row before it are the same move described twice, so every gap could be aimed at from two sides. The strip above the first row is the one place a drop under something cannot reach. A chapter could only be dropped into, never dragged past: taking the whole row as a place quietly took reordering away. The bottom edge of its header is the gap now, the rest of the row is still the chapter. A link showed the sheet of paper whatever it pointed at. The @ menu dropped the mark on the way into the link, and the refresh that keeps a link current ran once, while the editor was still empty -- content is poured in afterwards without an update event, so nothing ever looked again. The mark in the title bar and the box in a task list were each centred on a line box rather than on the letters in it, which is not the same as being on one line. The mark shares the title's baseline; the box is centred on the capitals and sized in em. Move to... is divided under headings that are deliberately not shaped like entries, and each row carries the mark its chapter or notebook wears. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This commit is contained in:
1 parent
2ffa357dfc
commit
a9391cdcf2
15 files changed
+724
-189
No files matched your search
+51
-6
@@ -279,15 +279,22 @@ try {
|
||||
/* Held and dropped in two steps, with a wait between: the highlight is React
|
||||
state, and asking for it in the same breath as the move that caused it reads
|
||||
the DOM before it has been drawn. */
|
||||
const holdOver = (dragId, chapterId) =>
|
||||
/* `where` picks the part of the row held over: a chapter is a place in the
|
||||
body of its header and a neighbour along the bottom edge of it, which is
|
||||
how a row can still be put in the gap under a chapter. */
|
||||
const holdOver = (dragId, chapterId, where = "body") =>
|
||||
p.evaluate(
|
||||
([from, to]) => {
|
||||
([from, to, part]) => {
|
||||
const row = document.querySelector(`[data-reorder-id="${from}"]`);
|
||||
const grip = row?.querySelector("[data-reorder-grip]");
|
||||
const target = document.querySelector(`[data-reorder-id="${to}"]`);
|
||||
if (!grip || !target) return `missing ${!!grip} ${!!target}`;
|
||||
const box = target.getBoundingClientRect();
|
||||
window.__drop = { x: box.x + box.width / 2, y: box.y + box.height / 2 };
|
||||
const head = target.querySelector("[data-reorder-head]") || target;
|
||||
const box = head.getBoundingClientRect();
|
||||
window.__drop = {
|
||||
x: box.x + box.width / 2,
|
||||
y: part === "edge" ? box.bottom - 2 : box.y + box.height / 2,
|
||||
};
|
||||
const fire = (el, type, x, y) =>
|
||||
el.dispatchEvent(
|
||||
new PointerEvent(type, {
|
||||
@@ -305,7 +312,7 @@ try {
|
||||
fire(window, "pointermove", window.__drop.x, window.__drop.y);
|
||||
return "held";
|
||||
},
|
||||
[dragId, chapterId]
|
||||
[dragId, chapterId, where]
|
||||
);
|
||||
|
||||
const letGo = () =>
|
||||
@@ -357,8 +364,15 @@ try {
|
||||
const shownChapters = await p
|
||||
.locator("[data-chapter-row]")
|
||||
.evaluateAll((els) => els.map((e) => e.getAttribute("data-chapter-row")));
|
||||
// The two strips at the ends of the list are drop targets, not rows: they
|
||||
// carry a reorder id and nothing else, least of all a grip to drag by.
|
||||
const noteId = rowOrder.find(
|
||||
(id) => id && !id.startsWith("sep-") && id !== "__end__" && !shownChapters.includes(id)
|
||||
(id) =>
|
||||
id &&
|
||||
!id.startsWith("sep-") &&
|
||||
id !== "__end__" &&
|
||||
id !== "__start__" &&
|
||||
!shownChapters.includes(id)
|
||||
);
|
||||
check(
|
||||
!!noteId && !!shownChapters[0],
|
||||
@@ -395,6 +409,37 @@ try {
|
||||
check(false, "a separator was there to drag", "none found");
|
||||
}
|
||||
|
||||
/* ── a chapter is a neighbour too ──
|
||||
* Taking the whole row as "into" quietly took reordering away: a chapter could
|
||||
* not be moved among its neighbours, and nothing could be put in the gap under
|
||||
* one. The bottom edge of the header is that gap, and asks for a line rather
|
||||
* than lighting the chapter up. */
|
||||
const looseLeft = (
|
||||
await p.locator("[data-reorder-id]").evaluateAll((els) => els.map((e) => e.dataset.reorderId))
|
||||
).find(
|
||||
(id) =>
|
||||
id &&
|
||||
!id.startsWith("sep-") &&
|
||||
id !== "__end__" &&
|
||||
id !== "__start__" &&
|
||||
!shownChapters.includes(id)
|
||||
);
|
||||
if (looseLeft) {
|
||||
const held = await holdOver(looseLeft, shownChapters[0], "edge");
|
||||
await p.waitForTimeout(400);
|
||||
const litAtEdge = await p.locator("[data-chapter-drop]").count();
|
||||
const lineAtEdge = await p.locator("[data-drop-line]").count();
|
||||
await letGo();
|
||||
await p.waitForTimeout(2000);
|
||||
check(
|
||||
held === "held" && litAtEdge === 0 && lineAtEdge === 1,
|
||||
"held over the bottom edge of a chapter, it offers a line instead of taking the row in",
|
||||
JSON.stringify({ held, litAtEdge, lineAtEdge })
|
||||
);
|
||||
} else {
|
||||
check(false, "a loose note was left to try the edge with", "none");
|
||||
}
|
||||
|
||||
/* ── a dialog does not close because a selection ended outside it ──
|
||||
* Select a word in the field, drag a little past the edge, let go: the click
|
||||
* lands on the backdrop — the nearest ancestor of press and release — and the
|
||||
|
||||
Reference in new issue
Block a user