Fix a permanent black line in the note list, and add separators

The drop indicator was a `borderTop` set in the same style object as a `border`
shorthand. Clearing the longhand resets its width and colour to the defaults
while the shorthand's `solid` stays, so a row kept a 2px black line for good —
measured at rest, before any drag. It is now its own element, which also stops
the list twitching as a row grows and shrinks by a pixel.

That element then turned out to be a dead strip of its own: it pushes the row
down as it appears, so the pointer ended up over the line rather than over the
row and releasing there dropped on nothing. The drag handlers moved to the whole
row and the indicator no longer takes pointer events. A strip below the last row
means "put it at the end", which otherwise needs a drop onto the final note.

Separators are lines drawn between notes, optionally named, stored on the
notebook beside its sort mode. They drag like notes do, and their position is
"how many notes come before me", so they hold their place as the notes around
them are renamed or edited. Shown only in the manual order — in "newest first"
the notes would slide past the line on every edit.

"All Notes" and "Starred" no longer offer a hand-made order: they are questions
asked of every notebook, so there is nothing for an arrangement to belong to.

199 unit tests, 190 browser checks across eleven suites.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This commit is contained in:
marcandClaude Opus 5 committed 2026-08-10 01:45:38 +02:00
1 parent 0a0864c58b
commit 2cee00e38e
10 files changed
+731 -125

No files matched your search

+30 -3
View File
@@ -23,7 +23,13 @@ import { ImportDialog } from "./ui/ImportDialog.jsx";
import { Sidebar } from "./ui/Sidebar.jsx";
import { Dashboard } from "./features/notebooks/Dashboard.jsx";
import { NoteList } from "./features/notes/NoteList.jsx";
import { DEFAULT_SORT, canReorder, sortNotes } from "./features/notes/noteSort";
import {
DEFAULT_SORT,
canReorder,
sortModesFor,
sortNotes,
withNewSeparator,
} from "./features/notes/noteSort";
import { EditorPane } from "./features/notes/EditorPane.jsx";
import { HistoryModal } from "./features/notes/HistoryModal.jsx";
import { DrawingLayer } from "./features/drawing/DrawingLayer.jsx";
@@ -79,7 +85,7 @@ export default function App() {
const { notes, notebooks, noteContents, backlinks } = data;
const search = useSearchIndex(user, notes, searchQuery);
const dnd = useNotebookDnd(data.reorderNotebooks);
const noteDnd = useNotebookDnd(data.reorderNotes);
const noteDnd = useNotebookDnd((dragId, targetId) => data.rearrange(activeFolder, dragId, targetId));
useEffect(() => sync.onSyncStatus(setSyncStatus), []);
@@ -168,9 +174,13 @@ export default function App() {
const activeNotebook = notebooks.find((nb) => nb.id === activeFolder) || null;
/* A real notebook remembers its order on the server; a view keeps one for the
session. Either way the note list is told a single mode. */
const sortMode = activeNotebook
const rawSortMode = activeNotebook
? activeNotebook.sortMode || DEFAULT_SORT
: virtualSort[activeFolder] || DEFAULT_SORT;
// A view has nowhere to keep a hand-made arrangement, so it cannot be in one —
// even if an older version of the app left "manual" behind on a notebook that
// has since been looked at through "All Notes".
const sortMode = !activeNotebook && rawSortMode === "manual" ? DEFAULT_SORT : rawSortMode;
const setSortMode = useCallback(
(mode) => {
@@ -180,6 +190,18 @@ export default function App() {
[activeNotebook, activeFolder, data]
);
/* ── Separators ──
* Lines the user draws between notes. They belong to the notebook's own
* arrangement, so they are stored on it and only ever shown in manual order. */
const separators = activeNotebook?.separators || [];
const writeSeparators = (next) =>
activeNotebook && void data.updateNotebook(activeNotebook.id, { separators: next });
const addSeparator = () => writeSeparators(withNewSeparator(separators, `sep-${Date.now().toString(36)}`));
const renameSeparator = (id, label) =>
writeSeparators(separators.map((s) => (s.id === id ? { ...s, label } : s)));
const removeSeparator = (id) => writeSeparators(separators.filter((s) => s.id !== id));
const isSearching = searchQuery.trim().length > 0;
const filteredNotes = useMemo(() => {
@@ -586,8 +608,13 @@ export default function App() {
trashedCount={trashedNotes.length}
snippetFor={search.snippetFor}
sortMode={sortMode}
sortModes={sortModesFor(!!activeNotebook)}
onSortModeChange={setSortMode}
reorderable={canReorder(sortMode, isSearching) && !!activeNotebook}
separators={separators}
onAddSeparator={addSeparator}
onRenameSeparator={renameSeparator}
onRemoveSeparator={removeSeparator}
dnd={noteDnd}
onToggleSidebar={() => setSidebarOpen(!sidebarOpen)}
onSelectNote={openNote}